Displayer for QueryRowsResult #1138
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wprzytula
changed the title
Michu1596
force-pushed
the
query_rows_result_displayer
branch
from
c8ad86d to
ddf3d5d
Compare
…ethods for using colors and setting terminal width
wprzytula
reviewed
Dec 8, 2024
scylla/src/transport/query_result.rs
Outdated
Comment on lines
458
to
466
| /// # use scylla::transport::query_result::{QueryResult, QueryRowsResult, RowsDisplayer}; | ||
| /// # fn example(query_result: QueryResult) -> Result<(), Box<dyn std::error::Error>> { | ||
| /// let rows_result = query_result.into_rows_result()?; | ||
| /// let mut displayer = RowsDisplayer::new(&rows_result); | ||
| /// displayer.set_terminal_width(80); | ||
| /// displayer.use_color(true); | ||
| /// println!("{}", displayer); | ||
| /// # Ok(()) | ||
| /// # } |
There was a problem hiding this comment.
🔧 Missing indentation in function's body.
|
note the difference between the way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Displayer for QueryRowsResult trying to mimic
cqlshway of displaying tables with one exception I implement the display for the duration type differently, because I thinkcqlshdisplays this type in an unclear way,for more details look in the comments.Fixes: #999
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.